Mahara

Javascript issue on /view/urls.php

Bug #1053766 reported by Son Nguyen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Won't Fix
Medium
Son Nguyen

Bug Description

Version: master
Platform: all
Browser: Javascript turned off

Issues:
 - 'Calendar' icon don't work
 - Clicking 'Save' button with correct time period causes error:

[WAR] 2e (lib/web.php:2625) redirect() should be called with either /[something] for local redirects or http[something] for absolute redirects
Call stack (most recent first):
redirect("S") at /home/sonn/code/mahara/htdocs/lib/mahara.php:1716
pieform_reply(0"Secret URL updated") at Unknown:0
call_user_func_array("pieform_reply", array(size 2)) at /home/sonn/code/mahara/htdocs/lib/pieforms/pieform.php:871
Pieform->reply(0"Secret URL updated") at /home/sonn/code/mahara/htdocs/view/urls.php:205
editurl_submit(object(Pieform), array(size 5)) at Unknown:0
call_user_func_array("editurl_submit", array(size 2)) at /home/sonn/code/mahara/htdocs/lib/pieforms/pieform.php:514
Pieform->__construct(array(size 5)) at /home/sonn/code/mahara/htdocs/lib/pieforms/pieform.php:161
Pieform::process(array(size 5)) at /home/sonn/code/mahara/htdocs/lib/pieforms/pieform.php:71
pieform(array(size 5)) at /home/sonn/code/mahara/htdocs/view/urls.php:137

Tags: javascript
Son Nguyen (ngson2000)
Changed in mahara:
importance: Undecided → High
status: New → Triaged
Revision history for this message
Son Nguyen (ngson2000) wrote :

The calendar icon should be removed when the browser does not support javascript.

Revision history for this message
Son Nguyen (ngson2000) wrote :

When deleting an existing secret URL, a confirmation box is required

Revision history for this message
Son Nguyen (ngson2000) wrote :

https://reviews.mahara.org/1751

Son Nguyen (ngson2000)
Changed in mahara:
assignee: nobody → Son Nguyen (ngson2000)
status: Triaged → In Progress
Revision history for this message
Son Nguyen (ngson2000) wrote :

Test cases for this bug:

Open this page view/urls.php of any view.

1. Click button 'Add' -> a new secret URL should show up.
2. Click button 'Save' -> no warning will show up any more.
3. The calendar icon will disappear, the help text for date and time input format: 'Use the format YYYY/MM/DD HH:MM' will display. This input format may change when you change the language.
4. Click X button (delete) -> a confirmation form will show up (see attached image).

Revision history for this message
Son Nguyen (ngson2000) wrote :

New patch: https://reviews.mahara.org/#/c/1841

Revision history for this message
Son Nguyen (ngson2000) wrote :

Test case note:

To access to this page
1. Login as an user
2. On the main menu, click Portfolio/Share
3. If you dont have a page or a collection, create one
4. Click 'Edit' button on the column 'Secret URLs'

Revision history for this message
Melissa Draper (melissa) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 milestone 1.8
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with undefined - http://www.enigmail.net/

iQIcBAEBAgAGBQJRIwvSAAoJEJHQT0Mtn5aHiTAQAMvv3UB+Std5sp7MNLJisIWM
F3w5pbCldLn86j6IA8nIGNAqebAOLiQ3AW3a5zO1LZ3lHy3Yp8En4sIPSOkF2U8L
6U/DF9pDo/z7cuo+GhtlgRe7oUyklpWNjgsF4/yw8ppYLuQ6eLgQiopyuZX6N7+a
NTQfXknHZIIEe4XhWmV2b9GGVF4Mhg1RUshsJe5/FvvC9ybXV+TTL/8HfFcdVL8e
lJfqu6Kjf4ueyp5dUXtHkh+GArjmT+O6j+bFRgR9rpvS4140JZimj05ZvjWzb6oS
zYgtyNap/T0rcyZP/upNweEhaWGAdJAMoO+GOIcSMDgTdWaAXyLlEgVfFOhx2IhT
sH6Dfuld4bCRsRLcrQwpKwcOB9xEYleCAXSeaZsVry9rfj2LWcrXzrBhPDsa7JQ0
qcPzymGh8kHHpVJPuaX3ztyaKPdS4jP8mz6CGnTwZ2ot2dDbbMBal4fkZfQ4j/cR
j1V9Q6HBU9RkcjXvcGFvYyA9HPMPVETQyx9mu/KYVtGf88Y9ucLlflQDsPskhZdQ
H8l9vEzdJLURAyq/YXKdrR14g9OgA+aqIWIO2E1YhjSO2kUAMBeRFjU/FEhftxPw
DkoR86wtix4QHeStPaA9PyPA1X825tdRQ9itqpBqbIgkKpD1Ue6hzf0aOvKX8+FJ
NSqftjUQEqadBbaQTqkP
=t4IF
-----END PGP SIGNATURE-----

Robert Lyon (robertl-9)
Changed in mahara:
importance: High → Medium
Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.