Refine the add/remove functionality the EQ presets
The current interaction of adding and removing presets in the equalizer leaves something to be desired. My proposal is as follows:
1. Remove the ability to edit existing presets. This removes complexity from the interfaces and ensures you can't mess up an existing preset unless you explicitly intend to remove it. This doesn't mean to make the sliders insensitive. Just don't save changes to existing presets.
2. If you change a preset, change the ComboBox to a ComboEntry in order to allow renaming. If a user inputs a name, save it to that name. If not, save it to a preset called "Custom".
3. Remove the entry in the dropdown that says "Add New..." and then just leave everything else the way it is ;)
Blueprint information
- Status:
- Complete
- Approver:
- Scott Ringwelski
- Priority:
- Medium
- Drafter:
- Danielle Foré
- Direction:
- Approved
- Assignee:
- Victor Martinez
- Definition:
- Approved
- Series goal:
- Accepted for trunk
- Implementation:
-
Implemented
- Milestone target:
-
0.3
- Started by
- Scott Ringwelski
- Completed by
- Scott Ringwelski
Related branches
Sprints
Whiteboard
Daniel, I've finished the implementation of this blueprint. If you want to test it, the code is here: https:/
Since I moved the default presets to the settings, you'll need to use 'sudo make install' in order to install the new schema.
Thanks in advance,
-- Victor
Victor's fix is very nice. however, based on this blueprint, you can no longer add new presets once you no longer have any defaults in your preset list because editing a custom preset does not result in adding a new one. How can we get around this? Maybe not allow the user to delete the "Flat" preset? - Scott
Scott, once you've deleted all the default presets, the "Add New" option appears again. I modified the addTopOptions() function in PresetList.vala to adapt to every possible case. -- Victor
I agree with Scott's solution but if one is already in place, I guess it's not that big of a deal. --DanRabbit
Cool, if there is a solution in place then I will go ahead and set the Implementation as completed. Thanks again! - Scott
Scott, thanks for marking this as completed. I'm still working on some improvements though. I'll keep you updated. --Victor
