Actions should return 'safe' validation errrors
Currently while there is full feedback from the serializers on their given errors, validation errors within the action return only 'actions invalid'.
While using the current tasks notes as feedback for this is probably not a good idea due to some unsafe information being passed into it, we need a solution for safe invalid errors. The feedback should be accessible and able to be viewed on clients like Horizon. This may cause an issue if we head towards asynchronous task processing, however this feedback would be useful in emails.
One possibility would be to remove action validation from the pre-approve step into it's own step, which could possibly be run before task execution. If we move towards async tasks and actions the removal of this from the pre-approve step could possibly be run before passing off the task to the async processor. This step could directly return error messages.
This may also include cleaning the task view code so that responses and errors are handled more centrally instead of having custom code for each taskview.
Blueprint information
- Status:
- Not started
- Approver:
- None
- Priority:
- Undefined
- Drafter:
- Amelia Cordwell
- Direction:
- Needs approval
- Assignee:
- None
- Definition:
- New
- Series goal:
- None
- Implementation:
-
Unknown
- Milestone target:
- None
- Started by
- Completed by