lp:charm-helpers

Author: James Page
Author Date: 2024-04-12 12:45:59 UTC

Merge pull request #881 from dosaboy/bug/1920770

Support checking service ports with ssl connection

Author: Frode Nordahl
Author Date: 2024-04-05 20:21:00 UTC

Merge pull request #890 from brianphaley/zed-backport-defer

Issue#743: fetch.ubuntu._run_with_retries raises on unexpected exitco…

Author: Felipe Reyes
Author Date: 2024-04-01 18:32:35 UTC

Merge pull request #879 from rodrigogansobarbieri/antelope_fix-image-volume-ambiguous-configuration

[antelope] Set service_user_id from keystone relation

Author: Alex Kavanagh
Author Date: 2024-03-22 19:59:44 UTC

Fix the spelling error in UBUNTU_OPENSTACK_RELEASE noble

Where noble shoule be nobel.

Author: Alex Kavanagh
Author Date: 2024-03-04 14:38:04 UTC

Merge pull request #856 from coreycb/bug/2037751/wallaby

Drop @cached decorator from openstack_release()

Author: Alex Kavanagh
Author Date: 2024-03-04 14:37:49 UTC

Merge pull request #854 from coreycb/bug/2037751/xena

Drop @cached decorator from openstack_release()

Author: Alex Kavanagh
Author Date: 2024-03-04 14:37:31 UTC

Merge pull request #853 from coreycb/bug/2037751/yoga

Drop @cached decorator from openstack_release()

Author: Felipe Reyes
Author Date: 2024-03-04 13:25:05 UTC

Merge pull request #875 from rodrigogansobarbieri/bobcat_fix-image-volume-ambiguous-configuration

[bobcat] Set service_user_id from keystone relation

Author: Hua Zhang
Author Date: 2023-11-02 14:34:38 UTC

cherry-pick the fix for lp bug 2021550 to victoria branch (#860)

* Allow users to disable wsgi socket rotation (#801)

The lp bug 1863232 introduced a new configuration option called
WSGISocketRotation which allows users to disable socket rotation on the apache
side. This patch will also allow setting this option on the charm side.

Other gerrit review links:
horizon: https://review.opendev.org/c/openstack/charm-openstack-dashboard/+/886373
cinder: https://review.opendev.org/c/openstack/charm-cinder/+/886356
keystone: https://review.opendev.org/c/openstack/charm-keystone/+/886377
ncc: https://review.opendev.org/c/openstack/charm-nova-cloud-controller/+/885836

Partial-Bug: 2021550
(cherry picked from commit 996f2410632b44a7dc207cc4bbfc1a38c83140a8)
Signed-off-by: zhhuabj <joshua.zhang@canonical.com>

* Rename wsgi-rotation to wsgi-socket-rotation

Commit 996f241 added support for new config option
'wsgi-rotation' but that name should have been
'wsgi-socket-rotation' in order to have a 1:1 relation
with the apache config it changes. The following patches
that implement this config are currently blocked until
this lands so that they can be synced before merge:

 * https://review.opendev.org/c/openstack/charm-ceilometer/+/887793
 * https://review.opendev.org/c/openstack/charm-cinder/+/886356
 * https://review.opendev.org/c/openstack/charm-glance/+/886376
 * https://review.opendev.org/c/openstack/charm-keystone/+/886377
 * https://review.opendev.org/c/openstack/charm-nova-cloud-controller/+/885836
 * https://review.opendev.org/c/openstack/charm-openstack-dashboard/+/886373

Related-Bug: #2021550
(cherry picked from commit 1a90eb03052102a2e8d906262f97e7f3ff87fcdc)
Signed-off-by: zhhuabj <joshua.zhang@canonical.com>

---------

Signed-off-by: zhhuabj <joshua.zhang@canonical.com>
Co-authored-by: Edward Hope-Morley <edward.hope-morley@canonical.com>

Author: Alex Kavanagh
Author Date: 2023-10-23 11:53:13 UTC

Fix pep8 issues

Author: Hua Zhang
Author Date: 2023-09-28 13:03:40 UTC

cherry-pick the fix for lp bug 2021550 to ussuri branch (#849)

* Allow users to disable wsgi socket rotation (#801)

The lp bug 1863232 introduced a new configuration option called
WSGISocketRotation which allows users to disable socket rotation on the apache
side. This patch will also allow setting this option on the charm side.

Other gerrit review links:
horizon: https://review.opendev.org/c/openstack/charm-openstack-dashboard/+/886373
cinder: https://review.opendev.org/c/openstack/charm-cinder/+/886356
keystone: https://review.opendev.org/c/openstack/charm-keystone/+/886377
ncc: https://review.opendev.org/c/openstack/charm-nova-cloud-controller/+/885836

Partial-Bug: 2021550
(cherry picked from commit 996f2410632b44a7dc207cc4bbfc1a38c83140a8)
Signed-off-by: zhhuabj <joshua.zhang@canonical.com>

* Rename wsgi-rotation to wsgi-socket-rotation

Commit 996f241 added support for new config option
'wsgi-rotation' but that name should have been
'wsgi-socket-rotation' in order to have a 1:1 relation
with the apache config it changes. The following patches
that implement this config are currently blocked until
this lands so that they can be synced before merge:

 * https://review.opendev.org/c/openstack/charm-ceilometer/+/887793
 * https://review.opendev.org/c/openstack/charm-cinder/+/886356
 * https://review.opendev.org/c/openstack/charm-glance/+/886376
 * https://review.opendev.org/c/openstack/charm-keystone/+/886377
 * https://review.opendev.org/c/openstack/charm-nova-cloud-controller/+/885836
 * https://review.opendev.org/c/openstack/charm-openstack-dashboard/+/886373

Related-Bug: #2021550
(cherry picked from commit 1a90eb03052102a2e8d906262f97e7f3ff87fcdc)
Signed-off-by: zhhuabj <joshua.zhang@canonical.com>

---------

Signed-off-by: zhhuabj <joshua.zhang@canonical.com>
Co-authored-by: Edward Hope-Morley <edward.hope-morley@canonical.com>

Author: Alex Kavanagh
Author Date: 2023-08-11 14:13:50 UTC

Merge pull request #837 from freyes/bug/1927277-train

Add function for retrieving subordinate services (#643)

Author: Chris MacNaughton
Author Date: 2022-04-01 10:30:44 UTC

Resolve type change in Ceph Quincy for enabled_manager_modules

Author: Billy Olsen
Author Date: 2022-03-14 16:54:43 UTC

Merge pull request #686 from ajkavanagh/queens-tempita

Remove tempita as it doesn't seem to be required anymore

Author: Alex Kavanagh
Author Date: 2022-03-14 16:54:39 UTC

Remove tempita as it doesn't seem to be required anymore (#684)

Cherry-pick from #674.

Author: Billy Olsen
Author Date: 2022-03-14 16:54:26 UTC

Merge pull request #685 from ajkavanagh/rocky-tempita

Remove tempita as it doesn't seem to be required anymore

Author: Felipe Reyes
Author Date: 2021-12-06 16:21:29 UTC

Add log statement to gain visibility on resolved addresses. (#661)

This change should allow the debugging of the bug LP: #1952414 which
seems to be related to situations where the endpoint is resolved to a
hostname and later in different calls to an IP address.

Related-Bug: #1952414

Author: Aurelien Lourot
Author Date: 2021-11-29 09:33:45 UTC

Merge pull request #660 from ajkavanagh/stable/21.10

Fix get_mon_map() for octopus and later

Author: Aurelien Lourot
Author Date: 2021-09-17 08:30:18 UTC

Merge pull request #640 from hemanthnakkina/lp1934129-stable/21.04

Add enable-fwaas to neutron api context

Author: Felipe Reyes
Author Date: 2021-02-02 16:04:27 UTC

Add JUJU_DEPARTING_UNIT support (#563)

Juju 2.8 introduced the new environment variable JUJU_DEPARTING_UNIT
which holds the name of the unit that's being removed, this allows
charm authors to remove the unit from the cluster during the execution
of the *-relation-departed hook.

https://discourse.charmhub.io/t/juju-2-8-0-release-notes/

Author: Rodrigo Barbieri
Author Date: 2020-11-21 17:14:14 UTC

update region_name on [placement] (#534) (#537)

The os_region_name option has been deprecated in Rocky [0]
and removed in Stein [1], therefore the template that is
used across all OpenStack releases needs to be updated to
include the region_name option, so nova-cloud-controller and
other charms consuming this template present both config
options to OpenStack, which will use the appropriate one
for the running release.

[0] https://github.com/openstack/nova/blob/master/releasenotes/notes/placement-via-ksa-02d87c87636912f8.yaml
[1] https://github.com/openstack/nova/blob/master/releasenotes/notes/remove-deprecated-placement-opts-aeffb090a2e94bdc.yaml

Related-bug: #1903210
(cherry picked from commit e7450c6e60129cad1754d4d0026582f4a10d0523)

Author: Frode Nordahl
Author Date: 2020-07-28 16:30:41 UTC

contrib/ceph: Tidy up long lines and update docstring format

In preparing for updates to the ``Pool`` classes I am doing some
tidying up as a separate commit to avoid too much thrashing in the
commits that does the functional changes.

Author: Aurelien Lourot
Author Date: 2020-07-22 09:15:16 UTC

Clean-up around adding linux bridges to OVS bridges (#449)

* Fix typo

* Mark OVS ports as managed by us

Before we used to mark only OVS interfaces

* add_ovsbridge_linuxbridge fixes

1. Fix missing 'ifup' on bionic.
2. Mark the OVS port also when upgrading the charm.

* Fix typos

* Use deprecate decorator

* Don't install ifupdown automatically

* Make dependency explicit

* Deprecate adding a linux bridge to an openvswitch bridge

* Minor improvements

* Make linter happy

* Raise on focal+

Author: Corey Bryant
Author Date: 2020-05-20 20:42:20 UTC

Add swift 2.25.0 version for ussuri (#473) (#475)

Also fixes unrelated pep8 failures that are surfacing.

Closes-Bug: 1879569
(cherry picked from commit 8a90d2cc3aa0ba170756bdc87b4499903ac86fe5)

Author: Joseph Borg
Author Date: 2020-02-04 09:11:17 UTC

Detect elementaryOS as Ubuntu to allow local testing (#426)

Author: Joseph Borg
Author Date: 2020-02-03 18:39:01 UTC

Add elementary to 100

Author: Frode Nordahl
Author Date: 2020-01-14 18:30:30 UTC

HostInfoContext: Fix retrieval of a hosts primary FQDN (#415) (#417)

* HostInfoContext: Fix retrieval of a hosts primary FQDN

The implementation of ``socket.getfqdn()`` in the standard Python
library does not exhaust all methods of getting the official name
of a host ref Python issue https://bugs.python.org/issue5004

Add a hint to the context based on local unit state for whether
fqdn should be used or not.

* HostInfoContext: use callback for charm controlled hint

Instead of forcing the charm authors hand as to how the
`use_fqdn_hint` is passed, provide a optional callback to let charm
author implement whichever way suits their charm.

Author: Mike Wilson
Author Date: 2019-08-21 12:17:03 UTC

Removing deduplication on add_op_request_access_to_group

Author: Liam Young
Author Date: 2019-08-08 10:22:29 UTC

Add context with info about running host (#357)

Author: David Ames
Author Date: 2019-04-11 16:45:57 UTC

Re-enable pgrep_full (#309)

pidof -x is not finding scripts run under python3 (like neutron-server).
pgrep -f has not problem finding them.

We had most of the plumbing already in place to use pgrep. It turns out
pidof is susceptible to the same problems pgrep does which led us to
change in the first place.

This change will fix a number of stein testing enrolment blockers.

Author: Joseph Borg
Author Date: 2019-03-11 11:50:14 UTC

Moving to factory and writing tests

Author: Cory Johns
Author Date: 2019-02-12 20:05:51 UTC

Handle migrated / moved packages in charm_helpers_sync

Some legacy charms use `charm_helpers_sync.py` to vendor in portions of
the charmhelpers library, rather than installing the full package. The
recent move of `charmshelpers.contrib.python` to
`charmhelpers.fetch.python` was broken with sync, despite the import
aliases put into place to maintain backward compatibility. This should
resolve that by handling migrations automatically when syncing.

Fixes #276

Author: Cory Johns
Author Date: 2019-02-04 16:20:13 UTC

Move contrib.python to fetch.python and add to docs

Author: Frode Nordahl
Author Date: 2019-01-31 16:45:16 UTC

Separate certificates with lineseparator in bundles (#260) (#271)

Fixes LP: #1810910

(cherry picked from commit cb2c2282f900a6e198b3578610c6c5375ea83292)

Author: Cory Johns
Author Date: 2018-09-11 19:45:52 UTC

Fix docs rendering on RTD

Author: Yang Kelvin Liu
Author Date: 2018-09-04 21:48:29 UTC

ensure max lenght of message in log func (#208)

Author: Aymen Frikha
Author Date: 2018-06-08 10:29:23 UTC

LP: #1748433 Ansible version changed from 2.0 to 2.5 and there is sev… (#181)

* LP: #1748433 Ansible version changed from 2.0 to 2.5

There is several changes in newer version. The default config of remote_tmp changed from " $HOME/.ansible/tmp" to "~/.ansible/tmp". Also Juju does not expand correctly tild character.

Closes-bug: LP#1748433

Author: David Ames
Author Date: 2018-03-28 18:23:14 UTC

Use non_zero_wait to override modulo 0

Push the unit % modulo == 0 logic to modulo_distribution. In
distributed_wait check for leadership and return 0 if the leader
or call modulo_distribution with non_zero_wait=True.

Author: David Ames
Author Date: 2018-03-21 22:52:30 UTC

Enable GRE conntrack in UFW

When using UFW on systems that also have GRE tunneling, GRE traffic
is marked INVALID unless nf_conntrack_proto_gre is loaded.

This change enables GRE connntrack when UFW is enabled if the unit is
not a container.

Closes-Bug: #1757564

Author: David Ames
Author Date: 2018-03-06 12:18:59 UTC

Update get_ca to include identity-credentials (#124)

* Update get_ca to include identity-credentials

When using keystone generated SSL with the identity-credentials
relation get_ca was ignoring ca data. Check both identity-service and
identity-credentials.

* update unit test for get_ca

Author: James Page
Author Date: 2018-01-22 17:17:15 UTC

Misc stable fixes (#96)

* Fix Swift package version check (#93)

Related-Bug: #1743847
(cherry picked from commit 395d849d3e44f7f58e0f95fccaedc695e835059b)

* Fix file permissions on config cache and unitdata (#94)

(cherry picked from commit 757c1b524f0766b00f9b07d9e6ac118e9f7ce3fa)

* Fix regression in NRPE haproxy check (#95)

These changes fix a regression in the haproxy NRPE checks when
gathering credentials for querying the admin haproxy endpoint,
to determine haproxy backend server health via the admin API.

(cherry picked from commit b2d968cd70a886aa8fee0c21bcd0b2f0501162a0)

* Make HAProxyContext network spaces aware (#92)

Use get_relation_ip in the HAProxy context. get_relation_ip is
IPv6, configuration and network spaces aware.

Partial-Bug: #1735421
(cherry picked from commit 416919061d1ff51d4f8910996856b13151270bf0)

* Support use of HAProxy context in dashboard charm (#98)

The Openstack Dashboard charm only has a public network binding,
which means the default HAProxy behaviour to inspect public,
internal and admin bindings breaks; support override of the
list of bindings to inspect during creation of the context.

(cherry picked from commit a69a671c457f1ca37dd3c26a7d20fd83a813f7cc)

Author: James Page
Author Date: 2017-11-29 15:42:16 UTC

Release: 0.18.3